Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS, fix lint workflow #25

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Update CODEOWNERS, fix lint workflow #25

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5665fa9
Update CODEOWNERS
cheshire137 Oct 16, 2024
a44439a
More targeted linting
cheshire137 Oct 16, 2024
fb25190
Switch lint Action
cheshire137 Oct 16, 2024
73dda31
More human-friendly linter workflow name
cheshire137 Oct 16, 2024
998baae
Also run the linter when the workflow changes
cheshire137 Oct 16, 2024
67c8556
Gotta checkout repo before go.mod is available
cheshire137 Oct 16, 2024
a63f31b
Lint when pushing to go.sum, too
cheshire137 Oct 16, 2024
07fb742
Test no error when Write'ing in tests for linter
cheshire137 Oct 16, 2024
dd13a17
Prob don't need check-latest
cheshire137 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @github/bento-reviewers
* @github/github-models-reviewers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ This is awesome!

Are there places in dotcom we should be making this substitution too? Happy to help with it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are! There's a PR in flight now to do so.

22 changes: 10 additions & 12 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,19 @@ name: "go-linter"
on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- "**.go"
- go.mod
- go.sum
merge_group:
workflow_dispatch:
push:
branches:
- 'main'
paths:
- "**.go"
- go.mod
- go.sum

permissions:
contents: read
Expand All @@ -21,21 +29,11 @@ jobs:
strategy:
fail-fast: false
runs-on: ubuntu-latest
env:
GOPROXY: https://proxy.golang.org/,direct
GOPRIVATE: ""
GONOPROXY: ""
GONOSUMDB: github.com/github/*
steps:
- uses: actions/setup-go@v5
with:
go-version: ${{ vars.GOVERSION }}
go-version-file: 'go.mod'
check-latest: true
- uses: actions/checkout@v4
- name: Lint
# This also does checkout, setup-go, and proxy setup.
uses: github/go-linter@v1.2.1
with:
strict: true
go-version: ${{ vars.GOVERSION }}
goproxy-token: ${{secrets.GOPROXY_TOKEN}}
uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a different linter since the other was giving errors about "Error: Unable to resolve action github/go-linter, not found".