Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with some grammars #3070

Closed
arfon opened this issue Jun 21, 2016 · 6 comments · Fixed by #3208
Closed

Issue with some grammars #3070

arfon opened this issue Jun 21, 2016 · 6 comments · Fixed by #3208
Assignees
Labels

Comments

@arfon
Copy link
Contributor

arfon commented Jun 21, 2016

There are a few grammars that I can't update because we fail to detect any scopes:

vendor/grammars/NSIS
vendor/grammars/sourcepawn
vendor/grammars/awk-sublime

To be honest I've not had a chance to figure out what's going on here but we get errors like this when running the tests (with the updated grammars):

3) Failure:
TestGrammars#test_local_scopes_are_in_sync [/Users/arfon/github/linguist/test/test_grammars.rb:70]:
The scopes listed for vendor/grammars/awk-sublime in grammars.yml don't match the scopes found in that repository.
Expected: ["source.awk"]
Actual: nil

This isn't a huge issue right now, except that we can't update grammars that throw errors like this. It's also a pain when trying to run git submodule update --remote as part of the release process for Linguist.

If anyone fancies trying to debug this then please be my guest. Otherwise I'll try and get to this at some point.

@arfon arfon added the Bug label Jun 21, 2016
@Alhadis
Copy link
Collaborator

Alhadis commented Jun 21, 2016

I'll have a look once I've finished posting a googolplex of orders at Discogs... (my streak this week is so empty, hahaha)

@arfon
Copy link
Contributor Author

arfon commented Jun 21, 2016

I'll have a look once I've finished posting a googolplex of orders at Discogs... (my streak this week is so empty, hahaha)

Awesome. Thanks!

Steps to replicate:

  • git submodule update --remote
  • bundle exec rake
  • giphy

@Alhadis
Copy link
Collaborator

Alhadis commented Jun 21, 2016

My intended procedure:

  • git submodule update --remote
  • bundle exec rake
  • STUFF HAPPENS
  • ?????
  • Resolve issue

I'll keep you posted, sir.

@pchaigno pchaigno self-assigned this Jun 26, 2016
@pchaigno
Copy link
Contributor

#3079 fixes the issue for both vendor/grammars/NSIS and vendor/grammars/awk-sublime.

The issue for vendor/grammars/sourcepawn seems to be a bit different. The author removed the grammar file and there doesn't seem to be a direct replacement (maybe the files in snippets but I can't find an entrypoint :/). I opened an issue at austinwagner/sublime-sourcepawn#10.

@Alhadis
Copy link
Collaborator

Alhadis commented Jun 28, 2016

☝️ Damn this guy stealing my thunder before I had a chance to investigate. :(

Okay, yeah, it seems like the author only intended for that repo to provide SourcePawn completions, as opposed to everything else that usually comes with a language-support package:

Sublime SourcePawn Completions
A Sublime Text 2 plugin that dynamically genenerates completions for SourcePawn.

And then a commit titled this:

Clean up a bunch of junk that ended up in here

Which removed the syntax definition file.

@pchaigno
Copy link
Contributor

☝️ Damn this guy stealing my thunder before I had a chance to investigate. :(

Sorry 🙇
There's still work to be done if the author doesn't add the grammar back though 😃
In that case we could add it back ourselves in another repository since it was under MIT license.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants