Markdown results: Change folder structure and add sample data for problem query #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
changed the title
aeisenberg
reviewed
Apr 20, 2022
| import { generateMarkdown } from '../../../../src/remote-queries/remote-queries-markdown-generation'; | ||
|
|
||
| describe('markdown generation', async function() { | ||
| it('for path-problem-query: should generate markdown file for each repo with results', async function() { |
There was a problem hiding this comment.
Minor: It might make sense to use nested describe blocks. So, here you would change to:
Suggested change
| it('for path-problem-query: should generate markdown file for each repo with results', async function() { | |
| describe('for path-problem-query', () => { | |
| it('should generate markdown file for each repo with results', async function() { |
And then fix indenting below. Same with the second test.
aeisenberg
approved these changes
Apr 20, 2022
shati-patel
force-pushed
the
shati-patel/sharing-paths
branch
from
5f08a29
to
50c9e16
Compare
Thanks for the tidy-up tip!
Correct! I'll have some more substantial changes in a follow-up PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #1302)
This PR adds sample data for a (non-path) problem query. Currently these are rendered the same, but I'll add special rendering for paths in a follow-up PR! See internal issue 👀
Checklist
N/A - internal only
ready-for-doc-reviewlabel there.