Skip to content

Commit

Permalink
gitpod: bump node-fetch version in extensions
Browse files Browse the repository at this point in the history
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
  • Loading branch information
Pothulapati authored and jeanp413 committed Apr 12, 2022
1 parent 4b8fd3f commit b23507f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion extensions/gitpod-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@
},
"dependencies": {
"gitpod-shared": "0.0.1",
"node-fetch": "^2.6.5",
"node-fetch": "2.6.7",
"uuid": "8.1.0",
"vscode-jsonrpc": "^5.0.1",
"vscode-nls": "^5.0.0",
Expand Down
4 changes: 2 additions & 2 deletions extensions/gitpod/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "%displayName%",
"description": "%description%",
"publisher": "gitpod",
"version": "0.0.28",
"version": "0.0.29",
"license": "MIT",
"preview": true,
"icon": "resources/gitpod.png",
Expand Down Expand Up @@ -45,7 +45,7 @@
"dependencies": {
"@gitpod/local-app-api-grpcweb": "main",
"@improbable-eng/grpc-web-node-http-transport": "^0.14.0",
"node-fetch": "^2.6.1",
"node-fetch": "2.6.7",
"tmp": "^0.2.1",
"vscode-nls": "^5.0.0"
},
Expand Down
7 changes: 7 additions & 0 deletions extensions/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,13 @@ ms@^2.0.0:
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.3.tgz#574c8138ce1d2b5861f0b44579dbadd60c6615b2"
integrity sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA==

node-fetch@2.6.7:
version "2.6.7"
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad"
integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ==
dependencies:
whatwg-url "^5.0.0"

node-addon-api@^3.2.1:
version "3.2.1"
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-3.2.1.tgz#81325e0a2117789c0128dab65e7e38f07ceba161"
Expand Down

0 comments on commit b23507f

Please sign in to comment.