Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in VScode issue (self hosted) #7360

Closed
hm2075 opened this issue Dec 24, 2021 · 7 comments
Closed

Open in VScode issue (self hosted) #7360

hm2075 opened this issue Dec 24, 2021 · 7 comments

Comments

@hm2075
Copy link

hm2075 commented Dec 24, 2021

Bug description

using main.2090 branch

open in vscode option returns

Failed to connect to Gitpod workspace black-xerinae-jgitsfxe: FetchError: request to https://xxx.com/static/bin/gitpod-local-companion-windows.exe failed, reason: certificate has expired

same issue on previous builds

Steps to reproduce

install main.2090 , open gitpod and select open in vscode

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@akosyakov
Copy link
Member

I think it is something wrong with your local certificates, probably they have to be updated.

@hm2075
Copy link
Author

hm2075 commented Dec 28, 2021

not entirely sure, certs are good
some other person mentioned the same issue in discord

@sedattanir
Copy link

I have same errors. My local certificates are signed by letsencrypt. I can't use this option. It does not give certificate error on localhost. The certificate appears to be signed.

@Pothulapati
Copy link
Contributor

Pothulapati commented Feb 3, 2022

Hey 👋🏼

Today, I ran into this, while running a self-hosted instance of gitpod with let's encrypt for SSL!

Based of comments from #5944 (comment), This happens when your server's root cert is cross signed by the already expired DST ROOT CA X3 issuer cert, while your client isn't updated with the latest open-ssl that takes into account of the other signer of the cert i.e ISRG ROOT X1. This cross-signing is done to maintain backward compatibility with android devices by let's encrypt by default!

gitpod extension which uses node-fetch npm dependency, and code's underlying electron, to perform a fetch call on the URI to download the remote-local-companion app seem to use an older version of an ssl library (possible openssl) that hasn't got the latest changes, and hence the expired root certificate error. (i'm not entirely sure yet, on who exactly is the problem here i.e node-fetch or underlying electron in code)

There are multiple ways to get around this:

  • Update the server to not have a root certificate that is cross signed by DST. For Self-Hosted, This means setting the preferredChain to ISRG Root X1 in the Issuer object of Cert Manager. I've tested this, and open in vs code seems to work after this change. But this means that the server would lose Android device compatibility prior to 7.1.0, which seems fine for gitpod self-hosted, as our clients are not native android clients, and this should work fine from browsers.

  • Obviously, Like you'd expect it's more of a client issue than the server, as let's encrypt s trying to do the right thing i.e maintain device compatibility, while its the client who is struck on a older version. As we can't skip SSL verification in the extension for security reasons, We could first try to see if using a latest version of node-fetch fixes it. If that doesn't fix it, then it could be a underlying old ver dependency issue in code 🤔

@Pothulapati
Copy link
Contributor

Pothulapati commented Feb 3, 2022

So, I was able to fix it by building a version of the gitpod extension that had a latest version of node-fetch. Obviously, As we can't expect servers to not have root certs signed by the expired DST ROOT CA X3 issuer. Updating the client, to use the latest version of SSL library that knows about ISRG Root X1 is the right way to fix this issue!

Will raise a PR, and update progress here in the issue! :)

Pothulapati added a commit to gitpod-io/openvscode-server that referenced this issue Feb 4, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Pothulapati added a commit to gitpod-io/openvscode-server that referenced this issue Feb 4, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
@Pothulapati
Copy link
Contributor

Pothulapati commented Feb 4, 2022

gitpod-io/openvscode-server#305 PR bumps the node-fetch, which fixed what I was facing locally but this could also be caused when they are using an older version of code (and thus getting an older version of electron). So, Updating Vs Code could very well fix the issue!

Thanks!

akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
@akosyakov
Copy link
Member

akosyakov commented Feb 7, 2022

It was published, please try. The fix should be since 0.0.29.

akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 8, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 8, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 10, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 10, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 10, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 11, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 10, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 11, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 30, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Mar 31, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 1, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 4, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 5, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 6, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 6, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 7, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 12, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 12, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 13, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 15, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 15, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 18, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 20, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 20, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 21, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 24, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 25, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 26, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
jeanp413 pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 28, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Apr 28, 2022
Related to gitpod-io/gitpod#7360

Currently, When the server has a root cert cross-signed by the
expired `DST ROOT CA X3`. There's a possiblity of the client having
an older version of `electron` in their code that causes the cert
expiry failure.

While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of `node-fetch`
also fixed the issue (not exactly sure why). This PR bumps the
`node-fetch` dependency to the one that the `code-server` uses.

Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants