gitpod: bump node-fetch version in extensions
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
LGTM, this also addresses CVE-2022-0235 (🎉 ). I want to wait until @jeanp413 is ok with merging, though, because I think he might be working on something there.
jeanp413
force-pushed
the
gp-code/main
branch
2 times, most recently
from
6cbcc36
to
7515109
Compare
akosyakov
force-pushed
the
tarun/node-fetch-bump
branch
from
d1b1fac
to
f498a6b
Compare
Related to gitpod-io/gitpod#7360 Currently, When the server has a root cert cross-signed by the expired `DST ROOT CA X3`. There's a possiblity of the client having an older version of `electron` in their code that causes the cert expiry failure. While, asking users to update their vs code should be our first suggestion, In some cases using the latest version of `node-fetch` also fixed the issue (not exactly sure why). This PR bumps the `node-fetch` dependency to the one that the `code-server` uses. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io>
akosyakov
force-pushed
the
tarun/node-fetch-bump
branch
from
f498a6b
to
8b464be
Compare
|
published, please try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to gitpod-io/gitpod#7360
Currently, When the server has a root cert cross-signed by the
expired
DST ROOT CA X3. There's a possiblity of the client havingan older version of
electronin their code that causes the certexpiry failure.
While, asking users to update their vs code should be our first
suggestion, In some cases using the latest version of
node-fetchalso fixed the issue (not exactly sure why). This PR bumps the
node-fetchdependency to the one that thecode-serveruses.Signed-off-by: Tarun Pothulapati tarun@gitpod.io