Adjusting date time text to match image size #22
Conversation
|
Just noticed this may resolve #18 to some extent as well. |
The `size` parameter isn't available in `load_default` until then.
- add `date_size` kwarg, supporting absolute font size or fraction - hopefully handle case where Pillow doesn't support FreeType, and you get a non-resizeable font back—don't want to loop forever trying to make it bigger! - fix text/rect positioning logic to avoid 1.6x scaling hack: turns out we can't assume the first two coords in `t_bbox` are (0, 0). Basically there seems to be some "inherent offset" in the font rendering?
There was a problem hiding this comment.
@ZachHoppinen thanks so much for working on this! The tiny font has always bothered me too. When I wrote all this originally, the built-in font with Pillow didn't support different sizes, but it seems that as of 10.1, the default font has changed and we can now do this. So thanks for looking into it.
I've played around with this a bit and am pushing a few changes:
- actually requiring Pillow 10.1 (otherwise passing
size=would throw an error with older versions) - exposing the size as an argument (both as a fraction, like you've done, and an absolute font size)
- figuring out why the text wasn't getting fully covered, instead of the 1.6x height workaround
- updating the docs with new examples showing how this looks, and how to use it
geogif/gif.py
Outdated
| img_fraction = 0.1 | ||
|
|
||
| # increment font until you get large enough font | ||
| while fnt.getbbox(test_label)[2] < img_fraction*test_img.size[0]: |
There was a problem hiding this comment.
The Pillow docs say this controls "The font size of Aileron Regular"—so if you don't have FreeType support and get the basic bitmap font (like previous versions of Pillow had), I think this would loop forever, since the font would never actually get bigger no matter what font size you asked for!
|
@ZachHoppinen I'll leave this for you to test out on your data, but I think it's good to go, so once you confirm I'll merge and cut a release! |
|
@gjoseph92 Just ran this on my data for a few different font sizes and fractions and it looks awesome now! Thanks for cleaning that all up and for this super cool project! |
|
Great to hear! Thanks for the contribution and figuring out the core change! |
Hello,
Feel free to close if this isn't helpful but when I use this great package with large xarray dataarrays the date text in the corner get very small and illegible. This push:
Credit to this slack exchange answer: https://stackoverflow.com/questions/4902198/pil-how-to-scale-text-size-in-relation-to-the-size-of-the-image
One weird thing I found was the background box was too short vertically after these changes so I added a 1.6x multiplier to the height to make the text work but I suspect I may just be missing something there.
Cheers!
Zach