-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting date time text to match image size #22
Merged
gjoseph92
merged 14 commits into
gjoseph92:main
from
ZachHoppinen:hoppinen_adjusing_text_size
May 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0db5d46
text size adjusted to image size
ZachHoppinen cd04ba3
Require Pillow 10.1
gjoseph92 a1c58b0
Improve font size handling
gjoseph92 e5f17ff
add netcdf to dev deps; storing array locally makes testing much faster!
gjoseph92 ffc8ae7
[driveby] update black
gjoseph92 4ad3fb0
[driveby] how did fps get to be 10 on dgif??
gjoseph92 f111e07
15% width looks nice
gjoseph92 e199ef4
update examples
gjoseph92 b601dcc
don't loop forever in edge case where label is empty string
gjoseph92 52307c0
pull out font logic into function for readability
gjoseph92 e567619
update tests
gjoseph92 4dc70e8
no default date_size in validation
gjoseph92 37ca772
docstring typo
gjoseph92 ac6b3f7
fix readthedocs with poetry
gjoseph92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pillow docs say this controls "The font size of Aileron Regular"—so if you don't have FreeType support and get the basic bitmap font (like previous versions of Pillow had), I think this would loop forever, since the font would never actually get bigger no matter what font size you asked for!