Reintroduce AST parse/walk #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gjtorikian
force-pushed
the
ast
branch
2 times, most recently
from
ddac545
to
d2d581f
Compare
|
Thanks @gjtorikian for getting this over the line! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces a feature which I had intentionally ripped out in the Rust write: the ability to
parsetext and manipulate the resulting node(s).To accomplish this, I had to do some truly awkward " serializing " as I couldn't get magnus to play very nicely with comrak's use of typed_arena (and more specifically, lifetimes). I end up having to get the node data, unpack it, iterate over it, and then turn the raw comrak data into Commonmarker Ruby-ish data. It's kind of a beautiful mess.
I only implemented a few AST methods for now, as I only needed a few for the project I'm working on.
xref #199