Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gitlab): change hostname to nullable and add default for useSsl in registry s3 spec #485

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix(gitlab): change hostname to nullable and add default for useSsl in registry s3 spec #485

merged 2 commits into from
Dec 22, 2023

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Dec 22, 2023

No description provided.

@kosmoz kosmoz requested a review from pmig December 22, 2023 09:38
@kosmoz kosmoz self-assigned this Dec 22, 2023
pmig
pmig reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also adapt the documentation.

@kosmoz kosmoz requested a review from pmig December 22, 2023 10:14
@pmig pmig merged commit 25fcc84 into main Dec 22, 2023
4 checks passed
@pmig pmig deleted the kosmoz/gitlab-registry-s3-default-ifx branch December 22, 2023 10:44
@christophenne christophenne mentioned this pull request Dec 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmig pmig pmig approved these changes

Assignees

@kosmoz kosmoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kosmoz @pmig