Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gitlab): change hostname to nullable and add default for useSsl in registry s3 spec #485

Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix(gitlab): change hostname to nullable and add default for useSsl in registry s3 spec #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d94eb8
fix(gitlab): change hostname to nullable and add default for useSsl i…
kosmoz Dec 22, 2023
b80d632
docs(gitlab): update crd reference
kosmoz Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/docs/03_crd-reference/gitlab/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ spec:
| secretKeySecret | SecretKeySelector | (required) |
| region | String | (required) |
| hostname | String | `null` |
| usePathStyle | Boolean | false |
| port | Integer | `null` |
| useSsl | Boolean | `null` |
| useSsl | Boolean | `true` |
| usePathStyle | Boolean | `false` |
4 changes: 2 additions & 2 deletions operator/src/main/kotlin/eu/glasskube/operator/apps/gitlab/GitlabRegistryStorageSpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ data class GitlabRegistryStorageSpec(
override val secretKeySecret: SecretKeySelector,
@field:Required
override val region: String,
override val hostname: String,
override val hostname: String?,
override val port: Int?,
override val useSsl: Boolean,
override val useSsl: Boolean = true,
override val usePathStyle: Boolean = false
) : CloudStorageSpec
}
Loading