Use boost::spirit for weights parsing. #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using boost::Spirit::X3 for weights parsing is significantly faster in startup. Current startup time goes from 3.5s to 2.8s. See also: leela-zero/leela-zero#805
|
Ah, yes, I had removed this originally to build on ubuntu 14.04. But it's not a big deal. I'm actually impressed it's faster than the raw strtof code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using boost::Spirit::X3 for weights parsing is significantly faster in
startup. On my machine time goes from 3.5s to 2.8s. This does not
add any link time dependencies as the parser is header only.
This should improve the amount of timeouts when loading into UI's,
thought it likely needs a fundamental fix.
See also:
leela-zero/leela-zero#805