Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tree reuse in training. #536

Merged
merged 11 commits into from
May 8, 2018
Merged

Disable tree reuse in training. #536

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae332a4
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps Apr 28, 2018
99e1bd7
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps May 1, 2018
2f5ad3f
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps May 3, 2018
c811dab
Fix play_one_game self-play logic.
Tilps May 4, 2018
26e5e4d
Disable tree reuse in training.
Tilps May 5, 2018
a1944b2
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps May 5, 2018
ca7b6a3
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps May 5, 2018
f1d601d
Merge remote-tracking branch 'refs/remotes/glinscott/next' into next
Tilps May 5, 2018
40ae310
Disable tree reuse in training.
Tilps May 5, 2018
9461dec
Add a comment.
Tilps May 5, 2018
43cfa99
Merge remote-tracking branch 'origin/no_tree_reuse' into no_tree_reuse
Tilps May 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UCI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ namespace {
// Return the score from the self-play game.
// Precondition: bh.cur() is not a terminal position.
int play_one_game(BoardHistory& bh) {
auto search = std::make_unique<UCTSearch>(bh.shallow_clone());
for (int game_ply = 0; game_ply < 450; ++game_ply) {
auto search = std::make_unique<UCTSearch>(bh.shallow_clone());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a comment saying we are doing this on purpose to avoid tree reuse? Otherwise it might look like a bug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Limits.startTime = now();
Move move = search->think(bh.shallow_clone());

Expand Down