Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: activities endpoint #5861

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Feat: activities endpoint #5861

merged 7 commits into from
Oct 18, 2024

Conversation

PeterSmallenbroek
Copy link
Contributor

@PeterSmallenbroek PeterSmallenbroek commented Sep 26, 2024 •
edited by azure-boards bot
Loading

AB#30438

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@PeterSmallenbroek PeterSmallenbroek added chore Something that does not affect the end user portalicious Changes related to the portalicious release labels Sep 26, 2024
diderikvw
diderikvw reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of great work to build on!

services/121-service/src/scoped.repository.ts Show resolved Hide resolved
services/121-service/src/utils/scope/createScopedRepositoryProvider.helper.ts Show resolved Hide resolved
@PeterSmallenbroek PeterSmallenbroek marked this pull request as ready for review October 17, 2024 12:52
@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) October 18, 2024 11:57
PeterSmallenbroek and others added 7 commits October 18, 2024 13:58
@PeterSmallenbroek
activity module & type
bc4ee2f
@PeterSmallenbroek
refactor: event scoped repository
6ad9400
@PeterSmallenbroek
repositories & types
bb02c0b
@diderikvw @PeterSmallenbroek
Activities review Peter's code (#5908)
ec37684 
Some comments and small changes
@aberonni @PeterSmallenbroek
activities: fix unit tests (#5914)
f669a41 
* activities: fix unit tests

* temporarily disable exports
@aberonni @PeterSmallenbroek
feat.activities: dto mapping to endpoint (#5911)
d9d0a0d 
* feat.activities: dto mapping to endpoint

AB#30664

* add permissions handling AB#30716

* One export per file
@PeterSmallenbroek @aberonni
Resolve TODOs activities endpoint (#5928)
de7d119 
* resolve TODOs

* Update services/121-service/src/activities/activities.controller.ts

Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>

---------

Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
aberonni
aberonni approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this based on the sub-branches already being reviewed

@aberonni aberonni enabled auto-merge (squash) October 18, 2024 12:05
@aberonni aberonni merged commit 0795d7c into main Oct 18, 2024
7 checks passed
@aberonni aberonni deleted the feat.activities-endpoint branch October 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diderikvw diderikvw diderikvw left review comments

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user portalicious Changes related to the portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterSmallenbroek @aberonni @diderikvw