Activities review Peter's code #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
pushed a commit
that referenced
this pull request
Oct 11, 2024
Some comments and small changes
aberonni
pushed a commit
that referenced
this pull request
Oct 11, 2024
Some comments and small changes
aberonni
pushed a commit
that referenced
this pull request
Oct 17, 2024
Some comments and small changes
aberonni
pushed a commit
that referenced
this pull request
Oct 17, 2024
Some comments and small changes
PeterSmallenbroek
pushed a commit
that referenced
this pull request
Oct 18, 2024
Some comments and small changes
PeterSmallenbroek
pushed a commit
that referenced
this pull request
Oct 18, 2024
Some comments and small changes
aberonni
added a commit
that referenced
this pull request
Oct 18, 2024
* activity module & type * refactor: event scoped repository * repositories & types * Activities review Peter's code (#5908) Some comments and small changes * activities: fix unit tests (#5914) * activities: fix unit tests * temporarily disable exports * feat.activities: dto mapping to endpoint (#5911) * feat.activities: dto mapping to endpoint AB#30664 * add permissions handling AB#30716 * One export per file * Resolve TODOs activities endpoint (#5928) * resolve TODOs * Update services/121-service/src/activities/activities.controller.ts Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl> --------- Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl> --------- Co-authored-by: diderikvw <diderik@diderikvanwingerden.com> Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#30708
Describe your changes
Comments and small changes to Peter's base code
Checklist before requesting a review