portalicious: add registrations breadcrumb and handle not found #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
cc502d3
to
8cdc413
Compare
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
8cdc413
to
e7ac5b4
Compare
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
e7ac5b4
to
59770f7
Compare
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
59770f7
to
5c9932f
Compare
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
5c9932f
to
029732e
Compare
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
029732e
to
0349ba2
Compare
AB#30165 AB#30395 I combined these two tasks because I found one relying on the other, and figured that they wouldn't be a large set of changes even when combined. The design of the "registration not found" deviates from what is in Figma based on a convo with Tal. I also took the liberty of adding a "project not found" error.
aberonni
force-pushed
the
aberonni/portalicious-breadcrumbs-and-not-found
branch
from
0349ba2
to
9e481da
Compare
arsforza
approved these changes
Oct 3, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#30165
AB#30395
I combined these two tasks because I found one relying on the other, and figured that they wouldn't be a large set of changes even when combined.
The design of the "registration not found" deviates from what is in Figma based on a convo with Tal.
I also took the liberty of adding a "project not found" error.
Checklist before requesting a review