portalicious: add registrations breadcrumb and handle not found v2 #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
added
the
portalicious
AB#30165 AB#30395 I combined these two tasks because I found one relying on the other, and figured that they wouldn't be a large set of changes even when combined. The design of the "registration not found" deviates from what is in Figma based on a convo with Tal. I also took the liberty of adding a "project not found" error.
aberonni
force-pushed
the
aberonni/breadrumbs-and-registrations-not-found-restored
branch
from
1a297d6 to
295542a
Compare
arsforza
approved these changes
Oct 3, 2024
aberonni
deleted the
aberonni/breadrumbs-and-registrations-not-found-restored
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#30165
AB#30395
I combined these two tasks because I found one relying on the other, and figured that they wouldn't be a large set of changes even when combined.
The design of the "registration not found" deviates from what is in Figma based on a convo with Tal.
I also took the liberty of adding a "project not found" error.
Re-creating this PR because something odd happened in #5882
Checklist before requesting a review