Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portalicious: payment and registration page review #6330

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Dec 20, 2024

AB#30048 AB#31172 AB#32368 AB#32457

This also includes some of the review fixes in #6309 (the other parts are in #6339)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6330.westeurope.5.azurestaticapps.net

@aberonni aberonni added the portalicious [DEPRECATED] Changes related to the Portalicious release label Dec 20, 2024
@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 15:02
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from a559978 to 58bafb4 Compare December 20, 2024 15:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
  • interfaces/Portalicious/src/app/components/page-layout/page-layout.component.html: Language not supported
  • interfaces/Portalicious/src/app/components/registration-page-layout/registration-page-layout.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.html: Language not supported
  • interfaces/Portalicious/src/styles.scss: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registrations/project-registrations.page.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/projects-overview/components/project-summary-card/project-summary-card.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-payment/components/retry-transfers-dialog/retry-transfers-dialog.component.ts: Evaluated as low risk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
  • interfaces/Portalicious/src/app/components/page-layout/page-layout.component.html: Language not supported
  • interfaces/Portalicious/src/app/components/registration-page-layout/registration-page-layout.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.html: Language not supported
  • interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
  • interfaces/Portalicious/src/locale/messages.xlf: Language not supported
  • interfaces/Portalicious/src/styles.scss: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/components/retry-transfers-dialog/retry-transfers-dialog.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-payments/components/payment-summary-card/payment-summary-card.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts: Evaluated as low risk
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from 5e9909a to a64574e Compare December 27, 2024 09:56
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from a64574e to a39b35f Compare December 27, 2024 10:09
@aberonni aberonni marked this pull request as ready for review December 27, 2024 10:09
@aberonni aberonni enabled auto-merge (squash) December 27, 2024 10:09
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from a39b35f to ed0136b Compare December 27, 2024 11:29
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from fd83dd2 to c20ba38 Compare January 3, 2025 12:33
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from c20ba38 to 44fdaed Compare January 3, 2025 12:35
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from 44fdaed to 04aaa72 Compare January 3, 2025 12:57
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from 04aaa72 to ef86346 Compare January 3, 2025 13:21
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from ef86346 to 800a584 Compare January 3, 2025 13:41
@aberonni aberonni force-pushed the aberonni/portalicious-payment-page-review branch from 800a584 to c42aff0 Compare January 3, 2025 14:08
@aberonni aberonni merged commit 20584ad into main Jan 3, 2025
11 checks passed
@aberonni aberonni deleted the aberonni/portalicious-payment-page-review branch January 3, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portalicious [DEPRECATED] Changes related to the Portalicious release
Development

Successfully merging this pull request may close these issues.

2 participants