Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portalicious: personal information attributes service #6339

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Dec 31, 2024

AB#32370 AB#31064

This also includes some of the review fixes in #6309 (the other parts are in #6330)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6339.westeurope.5.azurestaticapps.net

@aberonni aberonni added the portalicious [DEPRECATED] Changes related to the Portalicious release label Dec 31, 2024
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from ae783f5 to 08fe310 Compare December 31, 2024 09:24
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from 08fe310 to 3194671 Compare December 31, 2024 10:33
@aberonni aberonni marked this pull request as ready for review December 31, 2024 10:36
@Copilot Copilot bot review requested due to automatic review settings December 31, 2024 10:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.html: Language not supported
  • interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
  • interfaces/Portalicious/src/locale/messages.xlf: Language not supported
  • interfaces/Portalicious/src/app/components/registrations-table/registrations-table.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-registration-activity-log/project-registration-activity-log.page.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/activity-log-expanded-row/activity-log-expanded-row.component.ts: Evaluated as low risk
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from 3194671 to d64ee39 Compare December 31, 2024 10:43
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from d64ee39 to 7216da2 Compare January 2, 2025 11:06
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from 7216da2 to 29f5c84 Compare January 3, 2025 09:37
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from 29f5c84 to ab446fe Compare January 3, 2025 13:21
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from ab446fe to 4d0d280 Compare January 3, 2025 13:51
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from cd30481 to a55f4c9 Compare January 3, 2025 16:15
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from a55f4c9 to 6813af0 Compare January 3, 2025 16:19
@aberonni aberonni requested a review from Copilot January 4, 2025 08:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.html: Language not supported
  • interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
  • interfaces/Portalicious/src/locale/messages.xlf: Language not supported
  • interfaces/Portalicious/src/app/components/data-list/data-list.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-monitoring/project-monitoring.page.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-payments/components/create-payment/create-payment.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts:99

  • Ensure that this.registrationAttributes.data() is available before calling localizeAttribute to avoid potential runtime errors.
return this.registrationAttributeService.localizeAttribute({

interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts:104

  • Ensure that this.registrationAttributes.data() is available before calling localizeAttribute to avoid potential runtime errors.
return this.registrationAttributeService.localizeAttribute({
@aberonni aberonni enabled auto-merge (squash) January 6, 2025 18:04
@aberonni aberonni force-pushed the aberonni/portalicious-personal-information-refactor branch from 6813af0 to c7d91e9 Compare January 6, 2025 18:04
@aberonni aberonni merged commit c563a77 into main Jan 6, 2025
6 checks passed
@aberonni aberonni deleted the aberonni/portalicious-personal-information-refactor branch January 6, 2025 18:11
Piotrk39 pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portalicious [DEPRECATED] Changes related to the Portalicious release
Development

Successfully merging this pull request may close these issues.

2 participants