-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portalicious: personal information attributes service #6339
portalicious: personal information attributes service #6339
Conversation
ae783f5
to
08fe310
Compare
08fe310
to
3194671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
- interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.html: Language not supported
- interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
- interfaces/Portalicious/src/locale/messages.xlf: Language not supported
- interfaces/Portalicious/src/app/components/registrations-table/registrations-table.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registration-activity-log/project-registration-activity-log.page.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/activity-log-expanded-row/activity-log-expanded-row.component.ts: Evaluated as low risk
3194671
to
d64ee39
Compare
d64ee39
to
7216da2
Compare
7216da2
to
29f5c84
Compare
29f5c84
to
ab446fe
Compare
ab446fe
to
4d0d280
Compare
cd30481
to
a55f4c9
Compare
a55f4c9
to
6813af0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- interfaces/Portalicious/src/app/components/data-list/data-list.component.html: Language not supported
- interfaces/Portalicious/src/app/pages/project-registration-personal-information/project-registration-personal-information.page.html: Language not supported
- interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
- interfaces/Portalicious/src/locale/messages.xlf: Language not supported
- interfaces/Portalicious/src/app/components/data-list/data-list.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-monitoring/project-monitoring.page.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-payments/components/create-payment/create-payment.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/domains/project/project-attribute.helpers.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts:99
- Ensure that
this.registrationAttributes.data()
is available before callinglocalizeAttribute
to avoid potential runtime errors.
return this.registrationAttributeService.localizeAttribute({
interfaces/Portalicious/src/app/pages/project-registration-activity-log/components/table-cell-overview.component.ts:104
- Ensure that
this.registrationAttributes.data()
is available before callinglocalizeAttribute
to avoid potential runtime errors.
return this.registrationAttributeService.localizeAttribute({
AB#32370 AB#31064
6813af0
to
c7d91e9
Compare
AB#32370 AB#31064
This also includes some of the review fixes in #6309 (the other parts are in #6330)
Checklist before requesting a review
Portalicious preview deployment
https://lively-river-04adce503-6339.westeurope.5.azurestaticapps.net