Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1985 mark pending removal bad requests #1993

Merged
merged 5 commits into from
Jul 8, 2021

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jul 8, 2021

there were a couple of problems here:

  1. curator-service was passing parameters to data-service in the request body, when data-service was looking in the URI query
  2. curator-service was expecting 201 responses from data-service when it was sending 204
  3. curator-service was responding with 201 when it should have responded with 204

Have manually tested this end-to-end as well as using the unit tests, endpoints work now.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1993 (dbeeffc) into main (f787373) will increase coverage by 25.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1993       +/-   ##
===========================================
+ Coverage   56.18%   81.40%   +25.22%     
===========================================
  Files          76       56       -20     
  Lines        2645     1845      -800     
  Branches      842      337      -505     
===========================================
+ Hits         1486     1502       +16     
+ Misses       1159      343      -816     
Impacted Files Coverage Δ
...ion/curator-service/api/src/controllers/sources.ts 82.16% <100.00%> (ø)
...i/src/components/new-case-form-fields/NumCases.tsx
...c/components/landing-page/VerificationCodeForm.tsx
.../ui/src/components/new-case-form-fields/Events.tsx
...ation/curator-service/ui/src/hooks/useDebounce.tsx
...ion/curator-service/ui/src/components/ViewCase.tsx
...or-service/ui/src/components/CaseExcludeDialog.tsx
...e/ui/src/components/new-case-form-fields/Notes.tsx
.../components/new-case-form-fields/StyledTooltip.tsx
...n/curator-service/ui/src/components/util/links.tsx
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f787373...dbeeffc. Read the comment docs.

@iamleeg iamleeg merged commit 999e0a1 into main Jul 8, 2021
@iamleeg iamleeg deleted the 1985_markPendingRemoval_bad_requests branch July 8, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants