Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1985 mark pending removal bad requests #1993

Merged
merged 5 commits into from
Jul 8, 2021
Merged

1985 mark pending removal bad requests #1993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7478582
fix requirement that pending case params passed in URI query
iamleeg Jul 8, 2021
0e2030a
correct schema for status mark APIs: all should return 204
iamleeg Jul 8, 2021
7d894d9
Fix 500 error from pending removal API #1985
iamleeg Jul 8, 2021
bd7b3df
Update tests with expectation that 204 response comes from data service
iamleeg Jul 8, 2021
dbeeffc
Controller should return 204, not 201
iamleeg Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data-serving/data-service/api/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ paths:
type: string
responses:
'204':
$ref: '#/components/responses/204'
description: Cases were marked for removal.
'500':
$ref: '#/components/responses/500'
/cases/removePendingCases:
Expand All @@ -389,7 +389,7 @@ paths:
pattern: '^[a-f\d]{24}$'
responses:
'204':
$ref: '#/components/responses/204'
description: Cases were removed.
'500':
$ref: '#/components/responses/500'
/cases/clearPendingRemovalStatus:
Expand All @@ -413,7 +413,7 @@ paths:
type: string
responses:
'204':
$ref: '#/components/responses/204'
description: Marks were cleared.
'500':
$ref: '#/components/responses/500'
/cases/symptoms:
Expand Down
12 changes: 6 additions & 6 deletions verification/curator-service/api/openapi/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,8 @@ paths:
summary: Marks all cases recorded for this source as pending later removal.
operationId: markPendingRemoval
responses:
'201':
$ref: '#/components/responses/200'
'204':
description: Cases were marked.
'400':
$ref: '#/components/responses/400'
'403':
Expand All @@ -399,8 +399,8 @@ paths:
summary: All cases for this source that have the pending removal mark are deleted.
operationId: removePendingCases
responses:
'201':
$ref: '#/components/responses/200'
'204':
description: Cases were deleted.
'400':
$ref: '#/components/responses/400'
'403':
Expand All @@ -423,8 +423,8 @@ paths:
summary: Clears the removal pending status of any case from this source.
operationId: clearPendingRemovalStatus
responses:
'201':
$ref: '#/components/responses/200'
'204':
description: Marks were cleared.
'400':
$ref: '#/components/responses/400'
'403':
Expand Down
Loading