-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1995 split cases collection #2003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and does not need to filter cases. #1995
Notice the constraint that this never _moves_ a case: if you change the source ID from restricted to regular or vice versa, you need to delete and re-insert the case.
@abhidg @jim-sheldon fixed the date filtering now, this should be ready to go. |
abhidg
reviewed
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the package-lock.json diff (lockfileVersion changed, maybe due to different npm version?) other than that, looks good.
of pausing after clicking the button before checking for the menu item
abhidg
approved these changes
Jul 19, 2021
jim-sheldon
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does all the stuff to make sure that GISAID/other excluded sources don't get into the cases collection, and reverts to using
find()
queries instead of aggregations for looking up cases which is sometimes hundreds of times faster.What is doesn't do is migrate any of the existing data: AFAICT the only impact is that there's GISAID data in dev so we can delete and re-import if needed. No impact on prod.