Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2712 parameterise curator auth #2729

Merged
merged 2 commits into from
Jun 15, 2022
Merged

2712 parameterise curator auth #2729

merged 2 commits into from
Jun 15, 2022

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jun 14, 2022

This lets the reset request URL and welcome email text be configured by environment (specifically by disease name). The welcome text probably needs rewriting, as it has very old information about the number of COVID-19 cases in the COVID-19 line list. If we can get some generic text that could apply to any outbreak, it would make turnkey configuration of new instances much easier.

I've made the assumption that we'll be hosting other instances ourselves; if that changes, we change how URLs are calculated!

@codecov-commenter
Copy link

Codecov Report

Merging #2729 (a8625fc) into main (4712973) will decrease coverage by 26.03%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##             main    #2729       +/-   ##
===========================================
- Coverage   89.14%   63.11%   -26.04%     
===========================================
  Files          35       18       -17     
  Lines        1281     1212       -69     
  Branches      295      187      -108     
===========================================
- Hits         1142      765      -377     
- Misses        139      447      +308     
Impacted Files Coverage Δ
verification/curator-service/api/src/index.ts 88.63% <ø> (ø)
...n/curator-service/api/src/util/instance-details.ts 57.14% <57.14%> (ø)
...cation/curator-service/api/src/controllers/auth.ts 48.94% <66.66%> (ø)
...ta-serving/data-service/src/model/case-revision.ts
data-serving/data-service/src/model/event.ts
...g/data-service/src/model/preexisting-conditions.ts
data-serving/data-service/src/util/search.ts
data-serving/data-service/src/controllers/home.ts
...rving/data-service/src/controllers/preprocessor.ts
data-serving/data-service/src/model/date.ts
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e7bb7...a8625fc. Read the comment docs.

@iamleeg iamleeg merged commit 2cef3bb into main Jun 15, 2022
@iamleeg iamleeg deleted the 2712_parameterise_curator_auth branch June 15, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants