Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MacOS runners #1687

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Update MacOS runners #1687

merged 2 commits into from
Aug 14, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov marked this pull request as ready for review August 13, 2024 14:00
beqaabu
beqaabu previously approved these changes Aug 13, 2024
View reviewed changes
@atodorov atodorov marked this pull request as draft August 13, 2024 14:02
@atodorov
Copy link
Contributor Author

Building release artifacts on MacOS-13 passed here -> https://github.com/gluwa/creditcoin/actions/runs/10371263887/job/28711219498

@atodorov atodorov marked this pull request as ready for review August 13, 2024 15:17
@atodorov atodorov requested a review from beqaabu August 13, 2024 15:17
@atodorov atodorov merged commit 8f9815b into dev Aug 14, 2024
68 of 81 checks passed
@atodorov atodorov deleted the update-macos-runners branch August 14, 2024 06:21
atodorov added a commit to gluwa/creditcoin3 that referenced this pull request Aug 27, 2024
@atodorov
Use MacOS-13 runners for release
a689b20 
b/c MacOS 11 is no longer available. See:
gluwa/creditcoin#1687
@atodorov atodorov mentioned this pull request Aug 27, 2024
Merged
9 tasks
atodorov added a commit to gluwa/creditcoin3 that referenced this pull request Aug 27, 2024
@atodorov
Use MacOS-13 runners for release
89148c3 
b/c MacOS 11 is no longer available. See:
gluwa/creditcoin#1687
atodorov added a commit to gluwa/creditcoin3 that referenced this pull request Aug 27, 2024
@atodorov
Use MacOS-13 runners for release
6cc7348 
b/c MacOS 11 is no longer available. See:
gluwa/creditcoin#1687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@rustlang-dev rustlang-dev rustlang-dev approved these changes

@DylanVerstraete DylanVerstraete Awaiting requested review from DylanVerstraete

@beqaabu beqaabu Awaiting requested review from beqaabu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atodorov @BradleyOlson64 @beqaabu @rustlang-dev