Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MacOS-13 runners for release #447

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Use MacOS-13 runners for release #447

merged 1 commit into from
Aug 27, 2024

Conversation

atodorov
Copy link
Contributor

b/c MacOS 11 is no longer available. See:
gluwa/creditcoin#1687

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

b/c MacOS 11 is no longer available. See:
gluwa/creditcoin#1687
@atodorov atodorov requested a review from a team as a code owner August 27, 2024 08:34
Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit 89148c3 into dev Aug 27, 2024
46 of 53 checks passed
@atodorov atodorov deleted the testing/macos-13 branch August 27, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants