-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RE Notebook for Issue 200 #211
Conversation
Conflicts: dispatches/case_studies/renewables_case/PEM_parametrized_bidder.py dispatches/case_studies/renewables_case/RE_surrogate_optimization_steadystate.py dispatches/case_studies/renewables_case/run_double_loop.py dispatches/case_studies/renewables_case/run_double_loop_PEM.py dispatches/case_studies/renewables_case/tests/test_surrogate_opt.py dispatches/case_studies/renewables_case/wind_PEM_double_loop.py dispatches/workflow/parametrized_bidder.py
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 89.76% 89.76% -0.01%
==========================================
Files 74 74
Lines 8854 8853 -1
==========================================
- Hits 7948 7947 -1
Misses 906 906
☔ View full report in Codecov by Sentry. |
@dguittet I'm looking into the Linux "Notebooks checks" failures. They are very puzzling, as it looks like it's failing to find pytest plugins, and this is something I'd really not expect to be platform specific. I'll try to reproduce the error on a separate PR and keep you posted. EDIT: these should have been addressed by #212. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that all cells in the affected notebook are being run in CI, so we can be confident that the fixed version works (and therefore the last remaining item in #200 is resolved) .
Addresses issue:
#200
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: