Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RE Notebook for Issue 200 #211

Merged
merged 40 commits into from
Jul 14, 2023
Merged

Conversation

dguittet
Copy link
Contributor

Addresses issue:

#200

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Conflicts:
	dispatches/case_studies/renewables_case/PEM_parametrized_bidder.py
	dispatches/case_studies/renewables_case/RE_surrogate_optimization_steadystate.py
	dispatches/case_studies/renewables_case/run_double_loop.py
	dispatches/case_studies/renewables_case/run_double_loop_PEM.py
	dispatches/case_studies/renewables_case/tests/test_surrogate_opt.py
	dispatches/case_studies/renewables_case/wind_PEM_double_loop.py
	dispatches/workflow/parametrized_bidder.py
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (688999d) 89.76% compared to head (f28fc86) 89.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   89.76%   89.76%   -0.01%     
==========================================
  Files          74       74              
  Lines        8854     8853       -1     
==========================================
- Hits         7948     7947       -1     
  Misses        906      906              
Impacted Files Coverage Δ
...bles_case/RE_surrogate_optimization_steadystate.py 91.51% <ø> (-0.06%) ⬇️
...tudies/renewables_case/tests/test_surrogate_opt.py 73.91% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dguittet dguittet changed the title Fix 200 Fix RE Notebook for Issue 200 Jul 13, 2023
@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Jul 13, 2023

@dguittet I'm looking into the Linux "Notebooks checks" failures. They are very puzzling, as it looks like it's failing to find pytest plugins, and this is something I'd really not expect to be platform specific. I'll try to reproduce the error on a separate PR and keep you posted.

EDIT: these should have been addressed by #212.

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that all cells in the affected notebook are being run in CI, so we can be confident that the fixed version works (and therefore the last remaining item in #200 is resolved) .

image

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Jul 14, 2023
@lbianchi-lbl lbianchi-lbl linked an issue Jul 14, 2023 that may be closed by this pull request
3 tasks
@lbianchi-lbl lbianchi-lbl merged commit 5f38880 into gmlc-dispatches:main Jul 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Notebook Failures
3 participants