Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve nbcheck failures #212

Merged
merged 14 commits into from
Jul 14, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Jul 13, 2023

Resolves: failures due to gmlc-dispatches/nbcheck#1

Changes proposed in this PR:

  • Update dispatches-nbcheck version to 0.2.2

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (371f924) 89.76% compared to head (7048ce6) 89.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          74       74           
  Lines        8854     8854           
=======================================
  Hits         7948     7948           
  Misses        906      906           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl added bug Something isn't working Priority:High High Priority Issue or PR dependencies labels Jul 14, 2023
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review July 14, 2023 02:20
@lbianchi-lbl
Copy link
Contributor Author

@dguittet @radhakrishnatg this should address the weird failures for the notebook checks on Linux.

@lbianchi-lbl lbianchi-lbl merged commit 688999d into gmlc-dispatches:main Jul 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants