-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chain] move gnoland start
's genesis generation to cmd/genesis
#1952
Comments
Most def: #1885 I see no reason why not, since |
@harry-hov what's the status for this issue? #1988 is related but doesn't resolve this one. |
## Description This PR introduces the ability to specify a package directory that will recursively be added (deployed) to the `genesis.json`, utilizing the existing `gnoland genesis txs add` command. It also separates out the logic from `gnoland genesis txs add` into: - `gnoland genesis txs add sheets` for individual tx sheet files (ex. from tx-archive output) - `gnoland genesis txs add packages` for recursively adding packages (ex. `examples`) ![sample](https://github.com/gnolang/gno/assets/16712663/e88b363f-2911-454e-8002-46ee4cbecde6) Related: - #1952 - #1988 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
@Kouteki I've moved the milestone to post launch |
We need to figure out what to do with this now (following #2824) cc @zivkovicmilos |
Master issue: #1836;
From this issue comment: #1836 (comment)
At the moment, the gno.land node uses the
generateGenesisFile
function to set up the genesis file, including transactions, genesis balances and also the packages and realms in theexamples/
directory.Ideally, this step of genesis generation should be delegated to the
genesis
command; so thatgnoland start
only ever has to concern itself with starting the node proper. The long-term vision is that the Gno.land node should be able to run without needing a "root directory" (ie. being placed in the monorepo's directory structure).Proposed DoD
genesis packages
, with subcommands to:list
alladdpkg
transactions (what packages will be created at genesis)get
anaddpkg
transaction, filtering by pkgpath, showing the contents as well.del
anaddpkg
transaction, filteriing by pkgpath.add
to add a directory containing packages (ie.gnoland add examples
orgnoland add examples/gno.land/p/demo/avl
)generateGenesisFile
is doing right now.clear
to remove alladdpkg
transactions.default.genesis.json
genesis balances
, so they don't need to have separate filesdefault.genesis.json
withgenesis clear; genesis add ../examples
.@zivkovicmilos Question: do we plan a
gnoland init
command? (combiningconfig init
+secrets init
?). If so, shouldgenesis clear; genesis add ../examples
be a part of it?The text was updated successfully, but these errors were encountered: