Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement genesis transaction list command. #2400

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Jun 20, 2024

This is implementing some functionality described here: #1952.

Add a command for listing transactions and messages from genesis file. Examples:

Edit:

Changed to a JSON output. I'm using the existing objects themselves to serialize the output. Example:

    {
        "msg": [
            {
                "@type": "/vm.m_call",
                "caller": "g1u7y667z64x2h7vc6fmpcprgey4ck233jaww9zq",
                "send": "",
                "pkg_path": "gno.land/r/gnoland/blog",
                "func": "ModAddPost",
                "args": [
                    "post2",
                    "Second post",
                    "Lorem Ipsum",
                    "2022-05-20T13:17:23Z",
                    "",
                    "tag1,tag3"
                ]
            }
        ],
        "fee": {
            "gas_wanted": "2000000",
            "gas_fee": "1000000ugnot"
        },
        "signatures": [
            {
                "pub_key": {
                    "@type": "/tm.PubKeySecp256k1",
                    "value": "AnK+a6mcFDjY6b/v6p7r8QFW1M1PgIoQxBgrwOoyY7v3"
                },
                "signature": "sHjOGXZEi9wt2FSXFHmkDDoVQyepvFHKRDDU0zgedHYnCYPx5/YndyihsDD5Y2Z7/RgNYBh4JlJwDMGFNStzBQ=="
            }
        ],
        "memo": ""
    }
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro requested review from zivkovicmilos and a team as code owners June 20, 2024 11:48
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 20, 2024
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.79%. Comparing base (79a71a4) to head (de1dca4).

Files Patch % Lines
gno.land/cmd/gnoland/genesis_txs_list.go 84.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
+ Coverage   54.70%   54.79%   +0.09%     
==========================================
  Files         583      584       +1     
  Lines       78504    78744     +240     
==========================================
+ Hits        42946    43150     +204     
- Misses      32349    32369      +20     
- Partials     3209     3225      +16     
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.68% <85.18%> (+0.14%) ⬆️
tm2 54.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@albttx albttx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But rather than playing with awk can't we have a --json flag and ouput as a json array or as jsonl ? so then we can play easier with jq ?

@thehowl
Copy link
Member

thehowl commented Jun 20, 2024

agree with albert; I get the passion for UNIX awk and tab-separated stuff, but I like scripting with jq more

@zivkovicmilos
Copy link
Member

@ajnavarro
I think we're good to just assume all CLI output like this should be json by default, seeing the feedback on #2393

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro requested a review from albttx June 26, 2024 09:00
@ajnavarro
Copy link
Contributor Author

@zivkovicmilos changed to JSON output.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I've left a few comments, the most important one being for Amino

gno.land/cmd/gnoland/genesis_txs_list.go Outdated Show resolved Hide resolved
gno.land/cmd/gnoland/genesis_txs_list_test.go Outdated Show resolved Hide resolved
gno.land/cmd/gnoland/genesis_txs_list.go Outdated Show resolved Hide resolved
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jul 2, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ajnavarro ajnavarro merged commit 6a78488 into master Jul 2, 2024
82 of 83 checks passed
@ajnavarro ajnavarro deleted the feat/genesis-list branch July 2, 2024 13:10
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants