-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement genesis transaction list command. #2400
Conversation
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
==========================================
+ Coverage 54.70% 54.79% +0.09%
==========================================
Files 583 584 +1
Lines 78504 78744 +240
==========================================
+ Hits 42946 43150 +204
- Misses 32349 32369 +20
- Partials 3209 3225 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! But rather than playing with awk can't we have a --json flag and ouput as a json array or as jsonl ? so then we can play easier with jq ?
agree with albert; I get the passion for UNIX |
@ajnavarro |
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@zivkovicmilos changed to JSON output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
I've left a few comments, the most important one being for Amino
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This is implementing some functionality described here: #1952.
Add a command for listing transactions and messages from genesis file. Examples:
Edit:
Changed to a JSON output. I'm using the existing objects themselves to serialize the output. Example:
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description