Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gnokey] Add support for queries on a specific height #2231

Closed
leohhhn opened this issue May 28, 2024 · 4 comments
Closed

[gnokey] Add support for queries on a specific height #2231

leohhhn opened this issue May 28, 2024 · 4 comments

Comments

@leohhhn
Copy link
Contributor

leohhhn commented May 28, 2024

Description

Currently, calling queries at a specific height is not supported, even though the --height flag exists in gnokey. We should either implement this, or remove the flag until the functionality is implemented. Same goes for the --prove flag.

@moul
Copy link
Member

moul commented May 28, 2024

What are you hoping to query at a specific height? Do you have any hypothetical gnokey usage examples to share?

@linhpn99
Copy link
Contributor

linhpn99 commented May 28, 2024

#2234
@leohhhn Please consider this PR if we don't have a specific plan for implementing the logic for the two mentioned commands

@leohhhn
Copy link
Contributor Author

leohhhn commented May 28, 2024

@moul

I found it useful to check balances and other things at times when I was writing & testing smart contracts previously. It's not a major usecase, more of a nice-to-have.

I think it would be cool to have it, but if you disagree, I think we should remove it from the gnokey binary, as well as from the docs.

@linhpn99 Thanks, let's wait for @moul's opinion on this.

@moul
Copy link
Member

moul commented May 29, 2024

I’m against supporting custom height for balance checking. This is the role of an indexer, like Gnoscan. I suggest making feature requests to them or the DevX team, or consider defining specs for a new indexer.

I stay open for other queries such as retrieving a full block or something that’s cheap to compute.

thehowl pushed a commit that referenced this issue May 29, 2024
relate to #2231

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
omarsy pushed a commit to TERITORI/gno that referenced this issue Jun 3, 2024
relate to gnolang#2231

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@Kouteki Kouteki closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants