Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnokey): remove height and prove flags in query #2234

Merged
merged 9 commits into from
May 29, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented May 28, 2024

relate to #2231

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from jaekwon and a team as code owners May 28, 2024 16:37
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 28, 2024
@linhpn99 linhpn99 changed the title remove height and prove flags at gnokey query command fix: remove height and prove flags at gnokey query command May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.92%. Comparing base (088eeca) to head (ae40838).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   49.93%   49.92%   -0.02%     
==========================================
  Files         576      576              
  Lines       77828    77814      -14     
==========================================
- Hits        38865    38846      -19     
- Misses      35839    35842       +3     
- Partials     3124     3126       +2     
Flag Coverage Δ
tm2 54.50% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linhpn99 linhpn99 requested a review from moul as a code owner May 28, 2024 16:56
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr looks good, let's wait for @moul's feedback on original issue

@thehowl thehowl changed the title fix: remove height and prove flags at gnokey query command fix(gnokey): remove height and prove flags at gnokey query command May 29, 2024
@thehowl thehowl changed the title fix(gnokey): remove height and prove flags at gnokey query command fix(gnokey): remove height and prove flags in query May 29, 2024
@thehowl thehowl merged commit ac3a802 into gnolang:master May 29, 2024
9 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
relate to gnolang#2231

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants