Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: official documentation #1046
feat: official documentation #1046
Changes from 24 commits
d8f1599
0c84b03
b473202
b4e3f7c
57a9e7b
a10d126
955042a
630be8f
badb5d9
c7f611d
8845314
e93b74b
019650a
3a40dd4
da1fe7b
c940c2c
e2343c6
a324ce5
ab9c39a
db983b9
22c0cde
23a747f
cfc4459
38d9a12
679fa08
7842672
4ec69ee
7ae2920
9f7ab77
4ba996d
67f73b8
21283a8
35942e6
cd33a9c
ee0a7ff
acaf2aa
d004bb1
6d3e57c
531642c
db5eda0
e4ee8a0
43384c5
b6089ba
458598d
40fa990
00cbe6d
6bf83af
3603681
7254544
72e20b1
ecdb870
969e914
e89d450
1e627ef
fba2029
824816e
ef941e0
e8f1460
d6ee4da
43d4dba
b949947
7da892e
2206eac
4b6fa24
3c67978
f888653
b1ac173
6b68949
8ba08b8
90922f5
408f0fa
9073308
34de86c
5e9b9d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a word?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased:
40fa990
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about the file's usefulness. Shouldn't we keep it as a section within a binary document instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped as part of:
#1046 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check with latest changes if it's still appropriate?
cc @thehowl @gfanton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @thehowl @gfanton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gfanton wants to change this in #1233 to GNOHOME.
plus, some issues:
home
is actually not a "frequent" flag as far as I can see (we only have it ingnokey
, and maybegnofaucet
?). and even then, I tend to think that for this one we should have a long-term plan of not having it as a flag, and instead just use the env variable value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about this a bit, and I think we should probably just drop the common params doc, since it has a huge risk of going outdated. I am considering doing the same for all "tools" in the tooling section (their
--help
outputs are the most up-to-date documentation anyways)00cbe6d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like typo from our dev portal, we can get rid of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed:
6bf83af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a form, I suggest prioritizing opening the browser as the first option before suggesting the curl method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added:
969e914