-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(benchmarks): Rehauling Benchmark Workloads #2716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2716 +/- ##
==========================================
- Coverage 60.91% 60.82% -0.09%
==========================================
Files 564 357 -207
Lines 75267 31871 -43396
==========================================
- Hits 45849 19387 -26462
+ Misses 26047 10695 -15352
+ Partials 3371 1789 -1582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c8f8421
to
f7f8d07
Compare
cc @ajnavarro |
@sw360cab answering your questions:
I think so.
Github basic runners AFAIK are virtual machines sharing resources with other runs. From my experience, if we use GitHub default runners, historical benchmark data won't be useful, because it will be inaccurate (sometimes being faster than others, not knowing if it was for something we improved in our codebase, or because the GitHub node was overloaded that run). Having the same hardware always for benchmarks will also help a ton to compare performance improvements realistically.
If I understood correctly, I think we should only run one benchmark job at a time. |
TODO: get back README in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this 🙏
Just checked the bugs you mentioned; made a patch for the first one. The second one's solution is likely just to skip boltdb in testing. |
fixes #2711 The bug in the benchmark was introduced in #2418, which requires to run initStaticBlocks before running Preprocess, in most cases. (in normal scenarios, this is run by PredefineFileSet; however this benchmark is deep into the internals). Related: #2716. cc/ @sw360cab <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
f7f8d07
to
5a6ed61
Compare
4b7c155
to
ad27729
Compare
Close #2432 |
Things changes
Things unchanged
benchmark
repository will fetch from this into his owngh-pages
Things TODO (before merging)
Action
menu in Githubgh-repository
Things to consider (performance)