Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gnovm): run initStaticBlocks in BenchmarkPreprocess #2792

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Sep 13, 2024

fixes #2711

The bug in the benchmark was introduced in #2418, which requires to run initStaticBlocks before running Preprocess, in most cases. (in normal scenarios, this is run by PredefineFileSet; however this benchmark is deep into the internals).

Related: #2716. cc/ @sw360cab

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Sep 13, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.84%. Comparing base (1239f1d) to head (1d3612c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   60.83%   60.84%   +0.01%     
==========================================
  Files         563      563              
  Lines       75169    75169              
==========================================
+ Hits        45727    45738      +11     
+ Misses      26077    26068       -9     
+ Partials     3365     3363       -2     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (+0.81%) ⬆️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.21% <ø> (ø)
gnovm 65.59% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.09% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 5503cca into master Sep 16, 2024
119 of 120 checks passed
@thehowl thehowl deleted the dev/morgan/2711 branch September 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Benchamark Test panicking for GnoVM
2 participants