feat: allow Args on main run #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🤖 gnovm
Open
ajnavarro
commented
Jul 20, 2023
Comment on lines
+4
to
+10
| var Args []string | ||
|
|
||
| func init() { | ||
| Args = runtime_args() | ||
| } | ||
|
|
||
| func runtime_args() []string // in package runtime |
There was a problem hiding this comment.
I tried two possible solutions:
- Directly inject os.Args values when calling RunMain function on the VM. Problem:
ospackage is not available by default on the VM, you need VMKeeper for it. - Implementing
runtime_argsfunction somehow, returning the provided arguments.
There was a problem hiding this comment.
Second option.
I suggest: VMKeeper to be the preferred "frontend" for configuring the VM for advanced use cases like full context, multi-transaction features etc, while the raw gno.Machine remains suitable for single-test focused tasks.
Related with #1016.
After #1016 will be finished, I plan to migrate most of the gno CLI to it instead of gno.Machine, especially the REPL.
7 tasks
14 tasks
16 tasks
|
Closing this PR because it was just opened to get some feedback from @moul . More context here: #982 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to implement Args on main() runs.
Problem: I didn't find a clean way to inject os.Args values.
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the description