This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
xDAI Config changes #1429
Merged
xDAI Config changes #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velenir
approved these changes
Sep 22, 2020
Comment on lines
+8
to
+9
| // TODO: Pending review what makes sense here. How do gas prices are stablished in xDAI network | ||
| 100: undefined, |
There was a problem hiding this comment.
What does web3.eth.getGasPrice() return? Is it a variable number over time?
There was a problem hiding this comment.
I'll find out soon enough, I'm making a PR only for the gas, see #1398
| @@ -1,7 +1,7 @@ | |||
| import BN from 'bn.js' | |||
| import { assert } from '@gnosis.pm/dex-js' | |||
| import { assert, toBN } from '@gnosis.pm/dex-js' | |||
There was a problem hiding this comment.
Importing toBN from dex-js is ok here because it ultimately comes from web3 which is a peer dep for dex-js and therefore local web3 is used. But I would be wary of just importing any utility function because of potential version conflictsor duplicating deps.
For example if we ever need a function that makes use of bignumber.js and import it by the way of dex-js, it would be good to move bignumber.js to peer deps too.
Merged
This was referenced Oct 5, 2020
Closed
Merged
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1398
First of several xDAI PRs. The xDAI integration is not finished, see #1398 for more pending tasks
This one includes:
Depend on gnosis/dex-js#184