This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xDAI Config changes #1429
xDAI Config changes #1429
Changes from all commits
fd73133
4c37132
ca36c4e
b6accca
3a920c7
d1037f8
ca9e627
70f8ba0
e72e916
4197332
69724aa
9022458
5181ab0
8223a2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing
toBN
fromdex-js
is ok here because it ultimately comes fromweb3
which is a peer dep fordex-js
and therefore localweb3
is used. But I would be wary of just importing any utility function because of potential version conflictsor duplicating deps.For example if we ever need a function that makes use of
bignumber.js
and import it by the way ofdex-js
, it would be good to movebignumber.js
to peer deps too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
web3.eth.getGasPrice()
return? Is it a variable number over time?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll find out soon enough, I'm making a PR only for the gas, see #1398
This file was deleted.