Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-867 feat common calculation logic to separate package #162

Merged
merged 7 commits into from
Feb 19, 2024
Merged

GSW-867 feat common calculation logic to separate package #162

merged 7 commits into from
Feb 19, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Feb 14, 2024

New

  • tick_math, liquidity_amounts calculation logic is being used by multiple realms => make it as common package

TODO: wait for #160 #161 to merge, then change inner code

@r3v4s r3v4s self-assigned this Feb 14, 2024
mconcat
mconcat previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@mconcat mconcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing redundant functions across packages is a great improvement, thanks for the refactoring!

@notJoon
Copy link
Member

notJoon commented Feb 14, 2024

It's definitely became more concise, thanks for the work 👍

notJoon
notJoon previously approved these changes Feb 14, 2024
View reviewed changes
@r3v4s r3v4s dismissed stale reviews from notJoon and mconcat via 64fc5ac February 15, 2024 03:09
@r3v4s r3v4s force-pushed the GSW-867-feat-common-calculation-logic-to-separate-package branch from d0b2580 to 64fc5ac Compare February 15, 2024 03:09
@r3v4s r3v4s marked this pull request as ready for review February 15, 2024 03:09
@r3v4s
Copy link
Member Author

r3v4s commented Feb 15, 2024

@notJoon @mconcat Had to force push to fix conflicts. Please take a deep look a commit cf010d1

notJoon
notJoon reviewed Feb 15, 2024
View reviewed changes
README.md Show resolved Hide resolved
notJoon
notJoon previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any particular issues

mconcat
mconcat previously approved these changes Feb 16, 2024
View reviewed changes
@r3v4s r3v4s dismissed stale reviews from mconcat and notJoon via 7f527e6 February 16, 2024 11:04
@r3v4s r3v4s force-pushed the GSW-867-feat-common-calculation-logic-to-separate-package branch from 64fc5ac to 7f527e6 Compare February 16, 2024 11:04
@r3v4s r3v4s mentioned this pull request Feb 19, 2024
Merged
@r3v4s r3v4s merged commit 614798e into main Feb 19, 2024
@r3v4s r3v4s deleted the GSW-867-feat-common-calculation-logic-to-separate-package branch February 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconcat mconcat mconcat approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @mconcat