Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-863 feat: deploy without testcase #169

Merged
merged 5 commits into from
Feb 19, 2024
Merged

GSW-863 feat: deploy without testcase #169

merged 5 commits into from
Feb 19, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Feb 19, 2024

New

  1. when deploying contract, remove test coins from gno.mod

Fix

  1. scenario testcase
  2. live_test, init_only makefile

@r3v4s r3v4s self-assigned this Feb 19, 2024
@r3v4s
Copy link
Member Author

r3v4s commented Feb 19, 2024 •
edited
Loading

pr will be open when #162 #166 #168 are merged into main

UPDATED: ready for review

FYI, this pr includes bunch of test code modification, so for review please take a look this specific commit ad16198

@r3v4s r3v4s force-pushed the GSW-863-feat-deploy-without-testcase branch from 5a45424 to e260777 Compare February 19, 2024 08:52
@r3v4s r3v4s marked this pull request as ready for review February 19, 2024 08:53
@notJoon notJoon merged commit 1a0c567 into main Feb 19, 2024
@notJoon notJoon deleted the GSW-863-feat-deploy-without-testcase branch February 19, 2024 08:56
@r3v4s r3v4s restored the GSW-863-feat-deploy-without-testcase branch February 19, 2024 09:00
@r3v4s r3v4s deleted the GSW-863-feat-deploy-without-testcase branch February 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat mconcat approved these changes

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @mconcat