Skip to content

Commit

Permalink
Fix test delivery button in repo webhook settings page (#24478)
Browse files Browse the repository at this point in the history
Caused by
https://github.com/go-gitea/gitea/pull/24246/files#diff-2bfe41d93dbb409583a4f945902e46bb513f60f1c9301649c1689200c4f1466eR1

Class `new` was removed in #24246, but in function
`initCompWebHookEditor`, it will check `.new.webhook`.
So in repo webhook settings page, `initCompWebHookEditor` will init
nothing, and no response after click the test delivery button.

https://github.com/go-gitea/gitea/blob/da65b7ad47e8d0d82f47cb24ee9ac2a0ec50dc25/web_src/js/features/comp/WebHookEditor.js#L6-L9

Co-authored-by: Giteabot <teabot@gitea.io>
  • Loading branch information
yp05327 and GiteaBot committed May 2, 2023
1 parent bf999e4 commit bcdd3c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/repo/settings/webhook/new.tmpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings webhook")}}
{{template "repo/settings/layout_head" (dict "ctxData" . "pageClass" "repository settings new webhook")}}
<div class="repo-setting-content">
<h4 class="ui top attached header">
{{if .PageIsSettingsHooksNew}}{{.locale.Tr "repo.settings.add_webhook"}}{{else}}{{.locale.Tr "repo.settings.update_webhook"}}{{end}}
Expand Down

0 comments on commit bcdd3c3

Please sign in to comment.