Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Task panic recovery doesn't log the cause of the panic #13095

Closed
zeripath opened this issue Oct 11, 2020 · 0 comments · Fixed by #13096
Closed

Migrate Task panic recovery doesn't log the cause of the panic #13095

zeripath opened this issue Oct 11, 2020 · 0 comments · Fixed by #13096
Labels
type/bug

Comments

@zeripath
Copy link
Contributor

gitea/modules/task/migrate.go

Line 43 in 9066d09

fmt.Fprintf(&buf, "Handler crashed with error: %v", log.Stack(2))

Needs to log the e from the recover() as a %v just before the %v of the log.Stack

There are potentially other places where this error might have sneaked through.

References #13085
zeripath added a commit to zeripath/gitea that referenced this issue Oct 11, 2020
@zeripath
Log the underlying panic in runMigrateTask
d6e11a4 
If there is a panic during runMigrateTask we should capture and log the underlying
panic error.

This PR ensures that the panic is logged and captured as part of the task message.

Fix go-gitea#13095

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Oct 11, 2020
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Oct 11, 2020
@zeripath
Log the underlying panic in runMigrateTask (go-gitea#13096)
5031c15 
Backport go-gitea#13096

If there is a panic during runMigrateTask we should capture and log the underlying
panic error.

This PR ensures that the panic is logged and captured as part of the task message.

Fix go-gitea#13095

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Oct 11, 2020
Merged
techknowlogick pushed a commit that referenced this issue Oct 11, 2020
@zeripath
Log the underlying panic in runMigrateTask (#13096)
7edf7eb 
If there is a panic during runMigrateTask we should capture and log the underlying
panic error.

This PR ensures that the panic is logged and captured as part of the task message.

Fix #13095

Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick pushed a commit that referenced this issue Oct 11, 2020
@zeripath
Log the underlying panic in runMigrateTask (#13096) (#13098)
2bd7fee 
Backport #13096

If there is a panic during runMigrateTask we should capture and log the underlying
panic error.

This PR ensures that the panic is logged and captured as part of the task message.

Fix #13095

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Oct 11, 2020
@zeripath
Log the underlying panic in runMigrateTask (go-gitea#13096)
75a1ae6 
If there is a panic during runMigrateTask we should capture and log the underlying
panic error.

This PR ensures that the panic is logged and captured as part of the task message.

Fix go-gitea#13095

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log the underlying panic in runMigrateTask zeripath/gitea
1 participant
@zeripath