Log the underlying panic in runMigrateTask #13096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a panic during runMigrateTask we should capture and log the underlying panic error. This PR ensures that the panic is logged and captured as part of the task message. Fix go-gitea#13095 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #13096 +/- ##
==========================================
+ Coverage 42.41% 42.51% +0.09%
==========================================
Files 673 673
Lines 74114 74113 -1
==========================================
+ Hits 31436 31507 +71
+ Misses 37581 37488 -93
- Partials 5097 5118 +21
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Oct 11, 2020
GiteaBot
added
lgtm/need 1
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 11, 2020
Backport go-gitea#13096 If there is a panic during runMigrateTask we should capture and log the underlying panic error. This PR ensures that the panic is logged and captured as part of the task message. Fix go-gitea#13095 Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
approved these changes
Oct 11, 2020
GiteaBot
added
lgtm/done
zeripath
deleted the
fix-13095-improve-logging-of-panics-during-runMigrateTask
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 11, 2020
If there is a panic during runMigrateTask we should capture and log the underlying panic error. This PR ensures that the panic is logged and captured as part of the task message. Fix go-gitea#13095 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a panic during runMigrateTask we should capture and log the underlying
panic error.
This PR ensures that the panic is logged and captured as part of the task message.
Fix #13095
References #13085
Signed-off-by: Andrew Thornton art27@cantab.net