Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of email notifications for WIP draft PR's #14559

Closed
jpraet opened this issue Feb 3, 2021 · 0 comments · Fixed by #14663
Closed

Reduce amount of email notifications for WIP draft PR's #14559

jpraet opened this issue Feb 3, 2021 · 0 comments · Fixed by #14663
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@jpraet
Copy link
Member

jpraet commented Feb 3, 2021

Description

A WIP draft PR is not yet ready for review. In my opinion no notification should be sent yet when a WIP draft PR is created, when new commits are pushed to it, ... Offcourse, when explicitly @mentioning / assigning / requesting review from someone, they should still receive an email notification about that. And when someone leaves a code comment on a WIP draft PR, a notification should still be sent, but probably only to the author of the PR?

When the WIP status is removed, an email notification should be sent indicating it is ready for review.

What do you think?

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 4, 2021
jpraet added a commit to jpraet/gitea that referenced this issue Feb 12, 2021
don't notify repo watchers of WIP draft PR's
jpraet added a commit to jpraet/gitea that referenced this issue May 15, 2021
jpraet added a commit to jpraet/gitea that referenced this issue May 27, 2021
jpraet added a commit to jpraet/gitea that referenced this issue Jun 3, 2021
jpraet added a commit to jpraet/gitea that referenced this issue Jun 19, 2021
techknowlogick added a commit that referenced this issue Jun 23, 2021
* #14559 Reduce amount of email notifications for WIP draft PR's

don't notify repo watchers of WIP draft PR's

* #13190 Notification when WIP Pull Request is ready for review

* Send email notification to repo watchers when WIP PR is created

* Send ui notification to repo watchers when WIP PR is created

* send specific email notification when PR is marked ready for review

instead of reusing the CreatePullRequest action

* Fix lint error

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
* go-gitea#14559 Reduce amount of email notifications for WIP draft PR's

don't notify repo watchers of WIP draft PR's

* go-gitea#13190 Notification when WIP Pull Request is ready for review

* Send email notification to repo watchers when WIP PR is created

* Send ui notification to repo watchers when WIP PR is created

* send specific email notification when PR is marked ready for review

instead of reusing the CreatePullRequest action

* Fix lint error

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants