Improve notifications for WIP draft PR's

[jpraet]

Fixes #14559.
Fixes #13190.

• don't notify all repository watchers for creation, comments, commits, ... of WIP draft PR's (only send to participants of the PR)
• send a notification when the PR is marked ready for review

[zeripath]

Hmm I think abusing the pull created webhook for marking the draft as ready is a mistake.

Not least because you could change the name back and forth from wip: to not wip and potentially confuse things looking for new prs.

I also think repo watchers do want to know about draft prs being created - even if they don't then need to get informed about anything else until the pr is marked non draft

[jpraet]

Hmm I think abusing the pull created webhook for marking the draft as ready is a mistake.

Not least because you could change the name back and forth from wip: to not wip and potentially confuse things looking for new prs.

The webhooks are not affected. But indeed it can be confusing for users. How would I go about implementing that? Add an ActionPullRequestReadyForReview to the ActionType enum? It wouldn't ever be used in the actual action table though.

I also think repo watchers do want to know about draft prs being created - even if they don't then need to get informed about anything else until the pr is marked non draft

Fair point.

Edit: Currently implemented for the email notification. Not sure what the best approach is to detect this case in the UI notification too. I believe the issueNotificationOpts would need to be extended for that? Or I could determine the individual receivers in

gitea/modules/notification/ui/ui.go

Line 104 in 487f2ee

func (ns *notificationService) NotifyNewPullRequest(pr *models.PullRequest, mentions []*models.User) {

?

[codecov-io]

Codecov Report

Merging #14663 (1ae2a39) into master (9e852ed) will increase coverage by 0.00%.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##           master   #14663   +/-   ##
=======================================
  Coverage   42.22%   42.22%           
=======================================
  Files         767      767           
  Lines       81616    81636   +20     
=======================================
+ Hits        34464    34474   +10     
- Misses      41520    41526    +6     
- Partials     5632     5636    +4     

Impacted Files	Coverage Δ
modules/notification/ui/ui.go	60.97% <11.11%> (-3.94%)	⬇️
modules/notification/mail/mail.go	37.00% <14.28%> (-1.71%)	⬇️
services/mailer/mail_issue.go	64.36% <60.00%> (+0.41%)	⬆️
models/notification.go	66.33% <66.66%> (+0.08%)	⬆️
models/pull.go	55.45% <100.00%> (+0.27%)	⬆️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
services/pull/pull.go	42.15% <0.00%> (-0.50%)	⬇️
models/gpg_key.go	54.07% <0.00%> (+0.56%)	⬆️
services/pull/check.go	49.26% <0.00%> (+0.73%)	⬆️
modules/charset/charset.go	73.03% <0.00%> (+4.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e852ed...1ae2a39. Read the comment docs.

[codecov-commenter]

Codecov Report

Merging #14663 (a53362a) into main (0393a57) will increase coverage by 0.32%.
The diff coverage is 49.26%.

@@            Coverage Diff             @@
##             main   #14663      +/-   ##
==========================================
+ Coverage   44.24%   44.56%   +0.32%     
==========================================
  Files         695      701       +6     
  Lines       82341    83257     +916     
==========================================
+ Hits        36429    37106     +677     
- Misses      40014    40133     +119     
- Partials     5898     6018     +120     

Impacted Files	Coverage Δ
cmd/generate.go	0.00% <0.00%> (ø)
models/action.go	47.12% <ø> (ø)
models/oauth2.go	28.00% <0.00%> (-1.17%)	⬇️
models/user.go	52.32% <ø> (-1.07%)	⬇️
modules/context/repo.go	52.99% <0.00%> (-0.30%)	⬇️
modules/generate/generate.go	0.00% <0.00%> (-16.00%)	⬇️
modules/lfs/client.go	100.00% <ø> (ø)
modules/migrations/dump.go	0.00% <0.00%> (ø)
modules/setting/lfs.go	52.94% <0.00%> (ø)
modules/setting/repository.go	57.69% <ø> (ø)
... and 114 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6667f52...a53362a. Read the comment docs.