Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Use i18n.Reset to reload locales #15073

Merged
merged 7 commits into from
Mar 21, 2021
Merged

[refactor] Use i18n.Reset to reload locales #15073

merged 7 commits into from
Mar 21, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 20, 2021 •
edited
Loading

Follow up of #14582, by using Reset()

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 20, 2021
@6543 6543 added this to the 1.15.0 milestone Mar 20, 2021
@6543 6543 mentioned this pull request Mar 20, 2021
Closed
@6543
Copy link
Member Author

6543 commented Mar 20, 2021

PS: need gomod replace since unknwon/i18n#9 got not merged jet :/

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 20, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2021
lunny
lunny approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except I think the function name Flush should be Reset.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2021
@6543 6543 added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 21, 2021
@6543 6543 mentioned this pull request Mar 21, 2021
Merged
@6543
Copy link
Member Author

6543 commented Mar 21, 2021

look's like upstream get merged soon - so lets wait :)

@6543 6543 changed the title [refactor] Use i18n.Flush to reload locales [refactor] Use i18n.Reset to reload locales Mar 21, 2021
@6543 6543 removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 21, 2021
@6543
Copy link
Member Author

6543 commented Mar 21, 2021

🚀

@6543 6543 merged commit 24f7bd5 into go-gitea:master Mar 21, 2021
@6543 6543 deleted the only_i18n-flush branch March 21, 2021 15:11
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @zeripath @GiteaBot