-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default language to first element of LANGS #14846
Conversation
CI fail is related. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #14846 +/- ##
=========================================
Coverage ? 42.10%
=========================================
Files ? 777
Lines ? 83394
Branches ? 0
=========================================
Hits ? 35116
Misses ? 42573
Partials ? 5705
Continue to review full report at Codecov.
|
I don't think that's correct currently you are changing not default user language but fallback language that is not guaranteed to be 100% completed (translated) if you change default user language to something other |
you are right :/ ... I should call it Fallback and change it in this direction |
But is this really needed? What will happen if fallback language is missing translations? |
-> as you suggested it's english again |
As per discord: since this only cover edge case, just go with eng |
The first element of
LANGS
in[i18n]
section will be teh default language.Witch is used if no language is set to translate strings.