Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gravatar resolution mismatch #15453

Closed
2 of 6 tasks
finga opened this issue Apr 13, 2021 · 0 comments · Fixed by #15459
Closed
2 of 6 tasks

Gravatar resolution mismatch #15453

finga opened this issue Apr 13, 2021 · 0 comments · Fixed by #15459

Comments

@finga
Copy link
Contributor

finga commented Apr 13, 2021

Description

The avatars sourced by gravatar have a too small resolution which results in a pixelated gravatar avatar. This behaviour is also reporducible on https://try.gitea.io.
After some investigation it seems as gitea queries the default gravatar size of 80x80 pixel. Which means that the 80x80 pixel avatar is expanded to 260x260px. A diff between the default gravatar image with size 80x80 pixel and the avatar delivered by gitea does not gather any difference between those two files.

Screenshots

2021-04-13_17:44:23_3000x1920
zeripath added a commit to zeripath/gitea that referenced this issue Apr 13, 2021
@zeripath
Send size to /avatars if requested
8600533 
If an avatar is requested in a particular size ensure that /avatars also gets the
size request

Fix go-gitea#15453

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 13, 2021
Merged
6543 pushed a commit that referenced this issue Apr 16, 2021
@zeripath
Send size to /avatars if requested (#15459)
324cff6 
If an avatar is requested in a particular size ensure that /avatars also gets the size request

Fix #15453

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Apr 17, 2021
@zeripath
Send size to /avatars if requested (go-gitea#15459)
31a5ee1 
Backport go-gitea#15459

If an avatar is requested in a particular size ensure that /avatars also gets the size request

Fix go-gitea#15453

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 17, 2021
Merged
zeripath added a commit that referenced this issue Apr 17, 2021
@zeripath @6543
Send size to /avatars if requested (#15459) (#15528)
4a3c638 
Backport #15459

If an avatar is requested in a particular size ensure that /avatars also gets the size request

Fix #15453

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Send size to /avatars if requested (go-gitea#15459)
78bf904 
If an avatar is requested in a particular size ensure that /avatars also gets the size request

Fix go-gitea#15453

Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send size to /avatars if requested zeripath/gitea
1 participant
@finga