Send size to /avatars if requested #15459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an avatar is requested in a particular size ensure that /avatars also gets the size request Fix go-gitea#15453 Signed-off-by: Andrew Thornton <art27@cantab.net>
KN4CK3R
reviewed
Apr 14, 2021
| @@ -82,14 +82,19 @@ func (u *User) RealSizedAvatarLink(size int) string { | |||
| if u.Avatar == "" { | |||
| return DefaultAvatarLink() | |||
| } | |||
| if size > 0 { | |||
| return setting.AppSubURL + "/avatars/" + u.Avatar + "?size=" + strconv.Itoa(size) | |||
There was a problem hiding this comment.
What does the size parameter do?
There was a problem hiding this comment.
nothing right now - but we should probably keep sending it for future options
GiteaBot
added
the
lgtm/need 2
|
I think we should request higher resolution from gravatar, like requested image size times 2 like it is done for other images as well. Or maybe just hardcode to 580 which is enough for all UI use cases. https://secure.gravatar.com/avatar/f403e3d7796b4258b34481722014f370?d=identicon vs https://secure.gravatar.com/avatar/f403e3d7796b4258b34481722014f370?d=identicon&s=580 Or am I misunderstanding and this PR already does this? |
|
This PR means that if you request a size that size will get passed down to gravatar. |
silverwind
approved these changes
Apr 15, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 16, 2021
GiteaBot
added
lgtm/done
|
🚀 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 17, 2021
Backport go-gitea#15459 If an avatar is requested in a particular size ensure that /avatars also gets the size request Fix go-gitea#15453 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Apr 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an avatar is requested in a particular size ensure that /avatars also gets the
size request
Fix #15453
Signed-off-by: Andrew Thornton art27@cantab.net