Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong CSS for C code highlighting (light theme) #18670

Closed
braoult opened this issue Feb 8, 2022 · 1 comment · Fixed by braoult/gitea#1 or #18671
Closed

Wrong CSS for C code highlighting (light theme) #18670

braoult opened this issue Feb 8, 2022 · 1 comment · Fixed by braoult/gitea#1 or #18671

Comments

@braoult
Copy link
Contributor

braoult commented Feb 8, 2022 •
edited
Loading

Gitea Version

1.16.1

Operating System

N/A

Browser Version

N/A

Can you reproduce the bug on the Gitea demo site?

Yes

Description

The light theme does not make a difference between preprocessor directives (.cp) and comment lines (.cm):

.chroma .cm { color: #999988; } /* CommentMultiline */
.chroma .cp { color: #999999; } /* CommentPreproc */
.chroma .cpf { color: #999999; } /* CommentPreprocFile */

This makes the code difficult to read :

Screenshot_2022-02-08_11-50-04

.cp (and possibly .cpf) should be different than comments.

For example (I am not an artist, so the values below are not a suggestion :-) :

.chroma .cp { color: #109295 } /* CommentPreproc */
.chroma .cpf { color: #4C4DBC; } /* CommentPreprocFile */

Allow to have a more readable code :

Screenshot_2022-02-08_11-54-40
braoult added a commit to braoult/gitea that referenced this issue Feb 8, 2022
@braoult
C preprocessor colors improvement
63bc1dd 
Fixes go-gitea#18670
@braoult braoult mentioned this issue Feb 8, 2022
Merged
@braoult braoult reopened this Feb 8, 2022
@braoult
Copy link
Contributor Author

braoult commented Feb 8, 2022

Messed up repos... Re-opening for new PR.

@braoult braoult mentioned this issue Feb 8, 2022
Merged
zeripath pushed a commit that referenced this issue Feb 9, 2022
@braoult @KN4CK3R @lunny
C preprocessor colors improvement (#18671)
439ad34 
* C preprocessor colors improvement

Fixes #18670

* Update web_src/less/chroma/light.less

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* typo

missing semi

* add color for #include filenames

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 9, 2022
@braoult @KN4CK3R
@lunny @silverwind
C preprocessor colors improvement (go-gitea#18671)
20124e3 
* C preprocessor colors improvement

Fixes go-gitea#18670

* Update web_src/less/chroma/light.less

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* typo

missing semi

* add color for #include filenames

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this issue Feb 10, 2022
@silverwind @braoult
@KN4CK3R @lunny
C preprocessor colors improvement (#18671) (#18696)
649abed 
* C preprocessor colors improvement

Fixes #18670

* Update web_src/less/chroma/light.less

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* typo

missing semi

* add color for #include filenames

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Bruno Raoult <braoult@users.noreply.github.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@braoult @KN4CK3R @lunny
C preprocessor colors improvement (go-gitea#18671)
cdf0e4a 
* C preprocessor colors improvement

Fixes go-gitea#18670

* Update web_src/less/chroma/light.less

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* typo

missing semi

* add color for #include filenames

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C preprocessor colors improvement braoult/gitea
C preprocessor colors improvement braoult/gitea
1 participant
@braoult