C preprocessor colors improvement

[braoult]

Fixes #18670

C comments and preprocessor had nearly-same colors in light theme.
Old values:

.chroma .cm { color: #999988; } /* CommentMultiline */
.chroma .cp { color: #999999; } /* CommentPreproc */
.chroma .cpf { color: #999999; } /* CommentPreprocFile */

Proposed values:

.chroma .cp { color: #109295 } /* CommentPreproc */
.chroma .cpf { color: #4C4DBC; } /* CommentPreprocFile */

[lunny]

Hi, could you post some screenshots before and after?

[braoult]

Hi, could you post some screenshots before and after?

Screenshots were in #18670.

Before:

After:

[silverwind]

Please also check/show screenshot in dark theme (Settings -> Account -> Select default theme).

[braoult]

Please also check/show screenshot in dark theme (Settings -> Account -> Select default theme).

Dark theme has different colors for preprocessor lines, this is why I did not change anything there :

It does not have a different color for filenames, but this is not really an issue (I did hesitate before doing it to light theme). I mean filenames colors are much less important than full macro parsing (unsupported by chroma).

EDIT: I noticed some other discrepancies between light/dark themes : .s (string literal) and .se (string literal escaped characters) are different on dark theme, not on light theme, for example (and I must admit that I don't like at all the dark theme choice there) :

[silverwind]

Dark theme has a few issues like that, we need to fix them separately. Would appreciate if you could fix the ifdefs and filenames in dark theme as well. I think we could just copy the same colors as from light theme, maybe with slightly increased luminosity.

[braoult]

Dark theme has a few issues like that, we need to fix them separately. Would appreciate if you could fix the ifdefs and filenames in dark theme as well. I think we could just copy the same colors as from light theme, maybe with slightly increased luminosity.

I would be happy to do that, but there is something I do not understand in chroma files :-(
I am unsure where background colors are defined (for html & chroma). Is there some "magic" in dark.less so that background colors are correct without being defined there ?
Meantime, with these changes :

.chroma { --color-code-bg: #2a2e3a; }
.chroma .cpf { color: #03dfff; } /* CommentPreprocFile */

I can get something in chroma highlighting (but whole page & line numbers get light background. However, this is not very important here. Would those preprocessor (and include filenames) colors be OK (the only change is the blue color for include filenames) ?

If yes, I could ament my PR with .cpf value.

[silverwind]

Background color comes from --color-code-bg which is defined here:

gitea/web_src/less/_base.less

Line 124 in c14ca34

--color-code-bg: #ffffff;

gitea/web_src/less/themes/theme-arc-green.less

Line 121 in c14ca34

--color-code-bg: #2a2e3a;

So essentially, the chroma files do not set background because background comes from the base theme (we need to restructure theme variables into separate files later to be more clear).

Colors seem fine.

[zeripath]

make lgtm work